CP-9607: update android passkey implementation #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruijialin-avalabs
requested review from
neven-s,
atn4z7 and
onghwan
as code owners
| @@ -182,7 +182,7 @@ export const useSeedlessRegister = (): ReturnType => { | |||
| await SeedlessService.sessionManager.approveFido( | |||
| oidcAuth.oidcToken, | |||
| oidcAuth.mfaId, | |||
| false | |||
| true | |||
There was a problem hiding this comment.
this should be true instead, if we don't know it is yubikey/passkey, we want to prompt both options to them.
| await sessionManager.approveFido( | ||
| oidcToken, | ||
| mfaId, | ||
| false //FIXME: this parameter is not needed, should refactor approveFido to remove it, |
There was a problem hiding this comment.
this should be true instead, if we don't know it is yubikey/passkey, we want to prompt both options to them.
| ? decodedResult.response.signature | ||
| : '' | ||
| ) as Buffer, | ||
| userHandle: base64UrlToBuffer( |
There was a problem hiding this comment.
userHandle is null when authenticating with yubikey, so we check userhandle is in the reponse, if not, simply use empty string to convert to empty buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes done outside of mobile repo
cs org get(you will need to authenticate first) *we will need to make sure these org policy update is deploy from gamma to production prior to releasing this updateTicket: CP-9607
Screenshots/Videos
onboarding with android passkey and verifying android passkey
az_recorder_20250117_102851.mp4
Checklist
Please check all that apply (if applicable)